Remove namespace using in ETW exporter which affects global namespace #2531
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
There is a using of namespace
opentelemetry::exporter::etw
at the global scope in etw_provider.h. It causes naming clash for any one who includesetw_provider.h
which define the class name likeLogger
class.This PR defines an alias on the namespace
opentelemetry::exporter::etw
instead ofusing
it in global scope.For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes