Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove namespace using in ETW exporter which affects global namespace #2531

Merged

Conversation

ThomsonTan
Copy link
Contributor

Changes

There is a using of namespace opentelemetry::exporter::etw at the global scope in etw_provider.h. It causes naming clash for any one who includes etw_provider.h which define the class name like Logger class.

This PR defines an alias on the namespace opentelemetry::exporter::etw instead of using it in global scope.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@ThomsonTan ThomsonTan requested a review from a team February 12, 2024 20:01
Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good. Thanks for the fix.

@ThomsonTan ThomsonTan merged commit 8684a33 into open-telemetry:main Feb 12, 2024
47 checks passed
@ThomsonTan ThomsonTan deleted the remove_using_in_etw_exporter branch February 12, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants