Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EXAMPLES] Improve readme of Metrics example #2510

Merged
merged 2 commits into from
Jan 25, 2024

Conversation

ThomsonTan
Copy link
Contributor

Changes

Move the installation pointer to the beginning to help user to find it.

Add the definition of counter name in the example code.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@ThomsonTan ThomsonTan requested a review from a team January 25, 2024 01:11
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8da71b7) 87.09% compared to head (0e3b659) 87.09%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2510   +/-   ##
=======================================
  Coverage   87.09%   87.09%           
=======================================
  Files         200      200           
  Lines        6103     6103           
=======================================
  Hits         5315     5315           
  Misses        788      788           

@marcalff marcalff changed the title Improve readme of Metrics example [EXAMPLES] Improve readme of Metrics example Jan 25, 2024
Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@marcalff marcalff merged commit 14b74b9 into open-telemetry:main Jan 25, 2024
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants