Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUILD] Skip patch alias target #2457

Merged
merged 9 commits into from
Jan 8, 2024
Merged

Conversation

owent
Copy link
Member

@owent owent commented Dec 15, 2023

Fixes #2446

Changes

  • Skip patch alias target of cmake.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@owent owent requested a review from a team December 15, 2023 18:01
Patch CURL::libcurl_static and CURL::libcurl_shared
Copy link

codecov bot commented Dec 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f084fbc) 87.06% compared to head (d3caa84) 87.06%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2457   +/-   ##
=======================================
  Coverage   87.06%   87.06%           
=======================================
  Files         199      199           
  Lines        6087     6087           
=======================================
  Hits         5299     5299           
  Misses        788      788           

Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix.

@marcalff marcalff changed the title Skip patch alias target [BUILD] Skip patch alias target Jan 8, 2024
@marcalff marcalff merged commit c4f39f2 into open-telemetry:main Jan 8, 2024
46 checks passed
@owent owent deleted the fixes_2446 branch January 10, 2024 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CMake error when building with CURL 8.3.0 and higher
3 participants