-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUILD] 'uint8_t' not declared in this scope with gcc 13.2.1 #2423
[BUILD] 'uint8_t' not declared in this scope with gcc 13.2.1 #2423
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once the CLA is signed
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2423 +/- ##
=======================================
Coverage 87.06% 87.06%
=======================================
Files 199 199
Lines 6079 6079
=======================================
Hits 5292 5292
Misses 787 787
|
Thank you very much! I should be able to get the CLA signed by Monday: There is already an agreement in my company but I need to be added to a list of contributors by someone who will be back on Monday. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix. Please also fix the format of include order.
359d06d
to
62bd89c
Compare
Sorry for the delay, it took me a bit more time to get the CLA is signed. But it is now signed :-) |
Changes
Added missing header file in
hex.h
, required to declareuint8_t
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes