Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build] Update vcpkg to latest release #2412

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

ThomsonTan
Copy link
Contributor

@ThomsonTan ThomsonTan commented Nov 21, 2023

Fixes # (issue)

Changes

Update vcpkg submodule to 2023.10.19. The previous version seems to be out-of-date.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Merging #2412 (75e99e1) into main (cb603ad) will increase coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2412      +/-   ##
==========================================
+ Coverage   87.41%   87.43%   +0.02%     
==========================================
  Files         199      199              
  Lines        6028     6028              
==========================================
+ Hits         5269     5270       +1     
+ Misses        759      758       -1     

see 1 file with indirect coverage changes

@ThomsonTan ThomsonTan marked this pull request as ready for review November 21, 2023 03:50
@ThomsonTan ThomsonTan requested a review from a team November 21, 2023 03:50
@ThomsonTan ThomsonTan changed the title Update vcpkg to latest release [Build] Update vcpkg to latest release Nov 21, 2023
Copy link
Member

@esigo esigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks :)

@marcalff marcalff merged commit 8cba762 into open-telemetry:main Nov 21, 2023
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants