Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUILD] Fix protoc searching with non-imported protobuf::protoc target #2362

Merged
merged 2 commits into from
Oct 14, 2023
Merged

[BUILD] Fix protoc searching with non-imported protobuf::protoc target #2362

merged 2 commits into from
Oct 14, 2023
+5 −0

Conversation

owent
Copy link
Member

@owent owent commented Oct 12, 2023

Fixes #2360

Changes

Please provide a brief description of the changes here.

  • Fix protoc searching with non-imported protobuf::protoc target.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@owent owent requested a review from a team October 12, 2023 12:52
@codecov
Copy link

codecov bot commented Oct 12, 2023 •
edited
Loading

Codecov Report

Merging #2362 (371841d) into main (2c4b2a9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2362   +/-   ##
=======================================
  Coverage   87.41%   87.41%           
=======================================
  Files         199      199           
  Lines        6018     6018           
=======================================
  Hits         5260     5260           
  Misses        758      758

@andremarianiello
Copy link
Contributor

I filed #2360 and this fix worked for me. I would like to see it merged when possible. Thanks for the fix!

marcalff
marcalff approved these changes Oct 14, 2023
View reviewed changes
Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and fix tested by reporter.

Thanks for the fix.

@marcalff marcalff merged commit 3ff4b4c into open-telemetry:main Oct 14, 2023
44 checks passed
@marcalff marcalff changed the title Fix protoc searching with non-imported protobuf::protoc target. [BUILD] Fix protoc searching with non-imported protobuf::protoc target Oct 14, 2023
@owent owent deleted the fix_2360 branch October 16, 2023 06:08
@chenrui333 chenrui333 mentioned this pull request Oct 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcalff marcalff marcalff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cmake fails to correctly use non-imported protobuf::protoc target
3 participants
@owent @andremarianiello @marcalff