Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUILD] Build break with external CMake nlohman_json package #2353

Merged
merged 2 commits into from
Oct 10, 2023

Conversation

marcalff
Copy link
Member

@marcalff marcalff commented Oct 9, 2023

Fixes #2352

Changes

The unit test program otlp_http_log_record_exporter_test depends on nlohman_json.

Because of this, the dependency should be made explicit in CMakeList.tst

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@marcalff marcalff requested a review from a team October 9, 2023 13:04
@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Merging #2353 (e1decc5) into main (0eaa794) will decrease coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2353      +/-   ##
==========================================
- Coverage   87.41%   87.39%   -0.01%     
==========================================
  Files         199      199              
  Lines        6018     6018              
==========================================
- Hits         5260     5259       -1     
- Misses        758      759       +1     

see 1 file with indirect coverage changes

@marcalff marcalff mentioned this pull request Oct 9, 2023
@marcalff marcalff merged commit 18a27df into open-telemetry:main Oct 10, 2023
44 checks passed
@marcalff marcalff deleted the fix_json_build_break_2352 branch October 27, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUILD] Build break with external CMake nlohman_json package
3 participants