Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REMOVAL] Drop C++11 support #2342

Merged
merged 3 commits into from
Sep 30, 2023

Conversation

marcalff
Copy link
Member

@marcalff marcalff commented Sep 28, 2023

Fixes #2147

Changes

  • Drop C++11 support from CI.
  • Adjust documentation.

Note that building in C++11 may still work for a while, as the code and makefiles have not changed.
Opentelemetry-cpp makes however no commitments to maintain the C++11 build.
Bug fixes, new features, or third party dependencies may require C++14 from this point, without notice.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@marcalff marcalff requested a review from a team September 28, 2023 21:01
@marcalff marcalff marked this pull request as draft September 28, 2023 21:02
@marcalff marcalff mentioned this pull request Sep 25, 2023
@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Merging #2342 (11a17c8) into main (c3c643a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2342   +/-   ##
=======================================
  Coverage   87.39%   87.39%           
=======================================
  Files         199      199           
  Lines        6009     6009           
=======================================
  Hits         5251     5251           
  Misses        758      758           

@marcalff marcalff marked this pull request as ready for review September 28, 2023 22:06
@marcalff marcalff requested a review from owent September 28, 2023 22:06
@marcalff marcalff merged commit bd11434 into open-telemetry:main Sep 30, 2023
44 checks passed
@marcalff marcalff deleted the fix_drop_cpp11_2147 branch October 27, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REMOVAL] Drop C++11 support
3 participants