Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EXPORTER] Prometheus: Sanitize labels according to spec #2330

Merged
merged 1 commit into from
Sep 27, 2023
Merged

[EXPORTER] Prometheus: Sanitize labels according to spec #2330

merged 1 commit into from
Sep 27, 2023

Conversation

punya
Copy link
Member

@punya punya commented Sep 25, 2023 •
edited
Loading

Fixes #2289

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@punya punya force-pushed the sanitize-colons branch 3 times, most recently from 8e1c8c7 to 73b6ec6 Compare September 25, 2023 15:53
@punya punya marked this pull request as ready for review September 25, 2023 15:59
@punya punya requested a review from a team September 25, 2023 15:59
@punya punya force-pushed the sanitize-colons branch 2 times, most recently from 27a33b6 to 2692399 Compare September 25, 2023 16:01
@codecov
Copy link

codecov bot commented Sep 25, 2023 •
edited
Loading

Codecov Report

Merging #2330 (dd13fbc) into main (a4961c4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2330   +/-   ##
=======================================
  Coverage   87.45%   87.45%           
=======================================
  Files         199      199           
  Lines        5997     5997           
=======================================
  Hits         5244     5244           
  Misses        753      753

marcalff
marcalff approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix.

@marcalff marcalff merged commit a45081a into open-telemetry:main Sep 27, 2023
44 checks passed
@marcalff marcalff changed the title [exporters/prometheus] Sanitize labels according to Prometheus spec [EXPORTER] Prometheus: Sanitize labels according to spec Oct 11, 2023
@chenrui333 chenrui333 mentioned this pull request Oct 16, 2023
Merged
@punya punya deleted the sanitize-colons branch September 1, 2024 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcalff marcalff marcalff approved these changes

@lalitb lalitb lalitb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prometheus label keys must not include colons
3 participants
@punya @lalitb @marcalff