Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DEPRECATION] Deprecate ZPAGES #2291

Merged
merged 9 commits into from
Sep 5, 2023
Merged

[DEPRECATION] Deprecate ZPAGES #2291

merged 9 commits into from
Sep 5, 2023

Conversation

marcalff
Copy link
Member

@marcalff marcalff commented Sep 1, 2023

Fixes #2217

Changes

Please provide a brief description of the changes here.

  • Deprecate WITH_ZPAGES

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@marcalff marcalff requested a review from a team September 1, 2023 19:35
@marcalff marcalff mentioned this pull request Sep 1, 2023
Closed
@codecov
Copy link

codecov bot commented Sep 1, 2023 •
edited
Loading

Codecov Report

Merging #2291 (90ed164) into main (6eb09fa) will not change coverage.
The diff coverage is n/a.

❗ Current head 90ed164 differs from pull request most recent head a21a6b1. Consider uploading reports for the commit a21a6b1 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2291   +/-   ##
=======================================
  Coverage   87.52%   87.52%           
=======================================
  Files         199      199           
  Lines        5981     5981           
=======================================
  Hits         5234     5234           
  Misses        747      747

esigo
esigo approved these changes Sep 3, 2023
View reviewed changes
Copy link
Member

@esigo esigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
thanks :)

lalitb
lalitb reviewed Sep 3, 2023
View reviewed changes
DEPRECATED.md Show resolved Hide resolved
lalitb
lalitb reviewed Sep 3, 2023
View reviewed changes
DEPRECATED.md Show resolved Hide resolved
lalitb
lalitb approved these changes Sep 3, 2023
View reviewed changes
Copy link
Member

@lalitb lalitb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nit suggestions. Thanks.

@marcalff
Copy link
Member Author

marcalff commented Sep 3, 2023

LGTM with nit suggestions. Thanks.

Thanks, will adjust patch accordingly.

@marcalff marcalff merged commit cdbc90a into open-telemetry:main Sep 5, 2023
43 checks passed
@chenrui333 chenrui333 mentioned this pull request Oct 16, 2023
Merged
@marcalff marcalff deleted the fix_deprecate_zpages_2217 branch October 27, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esigo esigo esigo approved these changes

@owent owent owent approved these changes

@lalitb lalitb lalitb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DEPRECATION] Deprecate ZPAGES
4 participants
@marcalff @lalitb @owent @esigo