-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix more cases for symbol name for 32-bit win32 DLL build #2264
Merged
ThomsonTan
merged 4 commits into
open-telemetry:main
from
TomSvk88:FixSymbolNamesWin32DLL
Aug 21, 2023
Merged
Fix more cases for symbol name for 32-bit win32 DLL build #2264
ThomsonTan
merged 4 commits into
open-telemetry:main
from
TomSvk88:FixSymbolNamesWin32DLL
Aug 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomSvk88
force-pushed
the
FixSymbolNamesWin32DLL
branch
from
August 15, 2023 10:12
e3523d1
to
80176cb
Compare
lalitb
added
issue:blocked
Fix blocked, waiting for other fixes as prerequisites
and removed
issue:blocked
Fix blocked, waiting for other fixes as prerequisites
labels
Aug 16, 2023
ThomsonTan
approved these changes
Aug 18, 2023
lalitb
approved these changes
Aug 21, 2023
@ThomsonTan - Can we include this for next release ? |
Ok. Will include it in the coming release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2167 (issue)
Changes
Additional functions which are mangled differently between win32 and win64. Please see original issue for more details.
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes