Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix more cases for symbol name for 32-bit win32 DLL build #2264

Merged
merged 4 commits into from
Aug 21, 2023

Conversation

TomSvk88
Copy link
Contributor

Fixes #2167 (issue)

Changes

Additional functions which are mangled differently between win32 and win64. Please see original issue for more details.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@TomSvk88 TomSvk88 requested a review from a team August 15, 2023 09:58
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 15, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #2264 (a23dc8c) into main (4bfddde) will not change coverage.
The diff coverage is n/a.

❗ Current head a23dc8c differs from pull request most recent head cbe244a. Consider uploading reports for the commit cbe244a to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2264   +/-   ##
=======================================
  Coverage   87.52%   87.52%           
=======================================
  Files         199      199           
  Lines        5981     5981           
=======================================
  Hits         5234     5234           
  Misses        747      747           

@lalitb lalitb added issue:blocked Fix blocked, waiting for other fixes as prerequisites and removed issue:blocked Fix blocked, waiting for other fixes as prerequisites labels Aug 16, 2023
@lalitb
Copy link
Member

lalitb commented Aug 21, 2023

@ThomsonTan - Can we include this for next release ?

@ThomsonTan
Copy link
Contributor

@ThomsonTan - Can we include this for next release ?

Ok. Will include it in the coming release.

@ThomsonTan ThomsonTan merged commit 36fb921 into open-telemetry:main Aug 21, 2023
@TomSvk88 TomSvk88 deleted the FixSymbolNamesWin32DLL branch August 25, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Building as Win32 DLL failure
3 participants