[Metrics SDK] Add unit to Instrument selection criteria #2236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2236 +/- ##
==========================================
+ Coverage 87.31% 87.34% +0.03%
==========================================
Files 169 169
Lines 4900 4902 +2
==========================================
+ Hits 4278 4281 +3
+ Misses 622 621 -1
|
marcalff
reviewed
Jul 18, 2023
There was a problem hiding this comment.
LGTM.
Please add a CHANGELOG entry, similar to this:
Breaking changes:
* [SDK] MeterProvider should own MeterContext, not share it
[#2218](https://github.com/open-telemetry/opentelemetry-cpp/pull/2218)
* The `MeterProvider` constructor now takes a `unique_ptr` on
`MeterContext`, instead of a `shared_ptr`.
* Please adjust SDK configuration code accordingly.
marcalff
approved these changes
Jul 18, 2023
Agreed, looks better this way. |
esigo
approved these changes
Jul 19, 2023
sdk/include/opentelemetry/sdk/metrics/view/instrument_selector.h
Outdated
Show resolved
Hide resolved
esigo
added
the
ok-to-merge
|
Please add a CHANGELOG entry. |
Co-authored-by: Ehsan Saei <[email protected]>
…pp into add-unit-criteria
Done. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1995
This is breaking change for View/ViewFactory API:
Old:
View(name, desc, agg_type, agg_config, attribute_processor)New:
View(name, desc, unit, agg_type, agg_config, attribute_processor)Old:
ViewFactory::Create(name, desc, agg_type, agg_config, attribute_processor)New:
ViewFactory::Create(name, desc, unit, agg_type, agg_config, attribute_processor)Although the addition of the
unitas an optional last argument can prevent any breaking changes, I just felt it would be more logical to include it alongside thenameanddescarguments.Changes
Add unit to instrument selection criteria.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes