-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK] Provide builders to avoid exposing Metrics SDK internals #2189
[SDK] Provide builders to avoid exposing Metrics SDK internals #2189
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2189 +/- ##
==========================================
+ Coverage 87.53% 87.53% +0.01%
==========================================
Files 169 169
Lines 4888 4889 +1
==========================================
+ Hits 4278 4279 +1
Misses 610 610
|
Now ready for review. |
p->AddView(std::move(histogram_instrument_selector), std::move(histogram_meter_selector), | ||
std::move(histogram_view)); | ||
|
||
std::shared_ptr<opentelemetry::metrics::MeterProvider> provider(std::move(u_provider)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These multiple casts from api:::MeterProvider
-> sdk::MeterProvider
-> api::MeterProvider
are bit confusing, but seems we don't have better choice for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done, Thanks for the PR.
Fixes #1485
Changes
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes