Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEST] Add unit test for log body implicit conversions. #2136

Merged
merged 1 commit into from
May 11, 2023

Conversation

owent
Copy link
Member

@owent owent commented May 10, 2023

Fixes #2135

Changes

Please provide a brief description of the changes here.

  • Add unit test for log body implicit conversions.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@owent owent requested a review from a team May 10, 2023 05:29
@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Merging #2136 (9661851) into main (8308fc6) will increase coverage by 0.03%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2136      +/-   ##
==========================================
+ Coverage   87.15%   87.17%   +0.03%     
==========================================
  Files         166      166              
  Lines        4777     4777              
==========================================
+ Hits         4163     4164       +1     
+ Misses        614      613       -1     

see 1 file with indirect coverage changes

Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for improving the test coverage.

@ThomsonTan ThomsonTan merged commit 75d76a1 into open-telemetry:main May 11, 2023
@marcalff marcalff changed the title Add unit test for log body implicit conversions. [TEST] Add unit test for log body implicit conversions. May 23, 2023
@owent owent deleted the fix_2135 branch May 27, 2023 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add unit test for log body implicit conversions.
3 participants