Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEST] Add event id to logger benchmark method #2133

Merged

Conversation

ThomsonTan
Copy link
Contributor

Changes

Add the missing event id for a benchmark method.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@ThomsonTan ThomsonTan requested a review from a team May 5, 2023 23:53
@codecov
Copy link

codecov bot commented May 6, 2023

Codecov Report

Merging #2133 (981a281) into main (80f3018) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2133      +/-   ##
==========================================
- Coverage   87.19%   87.17%   -0.01%     
==========================================
  Files         166      166              
  Lines        4784     4777       -7     
==========================================
- Hits         4171     4164       -7     
  Misses        613      613              
Impacted Files Coverage Δ
.../include/opentelemetry/common/key_value_iterable.h 100.00% <ø> (ø)
...ude/opentelemetry/common/key_value_iterable_view.h 88.89% <ø> (ø)
api/include/opentelemetry/common/kv_properties.h 98.97% <ø> (ø)
api/include/opentelemetry/common/string_util.h 100.00% <ø> (ø)
api/include/opentelemetry/common/timestamp.h 80.44% <ø> (ø)
api/include/opentelemetry/context/context.h 100.00% <ø> (ø)
...lemetry/context/propagation/composite_propagator.h 100.00% <ø> (ø)
...ntelemetry/context/propagation/global_propagator.h 100.00% <ø> (ø)
...elemetry/context/propagation/text_map_propagator.h 50.00% <ø> (ø)
...pi/include/opentelemetry/context/runtime_context.h 97.60% <ø> (ø)
... and 31 more

Copy link
Member

@owent owent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and thanks.

@ThomsonTan ThomsonTan merged commit 8308fc6 into open-telemetry:main May 8, 2023
@ThomsonTan ThomsonTan deleted the add_event_id_to_benchmark branch May 8, 2023 00:15
@marcalff marcalff changed the title Add event id to logger benchmark method [TEST] Add event id to logger benchmark method May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants