Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Upgrade Nlohmann JSON library version from 3.10.5 to 3.11.2 #2115

Merged
merged 1 commit into from
Apr 27, 2023
Merged

[CI] Upgrade Nlohmann JSON library version from 3.10.5 to 3.11.2 #2115

merged 1 commit into from
Apr 27, 2023

Conversation

cngzhnp
Copy link
Contributor

@cngzhnp cngzhnp commented Apr 23, 2023

Fixes # (issue)

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@codecov
Copy link

codecov bot commented Apr 23, 2023 •
edited
Loading

Codecov Report

Merging #2115 (f138ed7) into main (a39e8b5) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2115   +/-   ##
=======================================
  Coverage   87.19%   87.19%           
=======================================
  Files         166      166           
  Lines        4784     4784           
=======================================
  Hits         4171     4171           
  Misses        613      613

@cngzhnp cngzhnp force-pushed the feature/update_nlohmann_json_version branch 2 times, most recently from 8c4be6d to ce73342 Compare April 23, 2023 18:37
@cngzhnp cngzhnp force-pushed the feature/update_nlohmann_json_version branch from ce73342 to f138ed7 Compare April 23, 2023 18:38
@cngzhnp cngzhnp marked this pull request as ready for review April 23, 2023 19:31
@cngzhnp cngzhnp requested a review from a team April 23, 2023 19:31
marcalff
marcalff approved these changes Apr 24, 2023
View reviewed changes
Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix

@lalitb lalitb merged commit fbcf3aa into open-telemetry:main Apr 27, 2023
@marcalff marcalff changed the title Upgrade Nlohmann JSON library version from 3.10.5 to 3.11.2 [CI] Upgrade Nlohmann JSON library version from 3.10.5 to 3.11.2 May 23, 2023
@chenrui333 chenrui333 mentioned this pull request May 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcalff marcalff marcalff approved these changes

@owent owent owent approved these changes

@lalitb lalitb lalitb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cngzhnp @lalitb @owent @marcalff