Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EXPORTER] Fixed HTTP session cleanup on shutdown #2111

Merged
merged 4 commits into from
Apr 27, 2023

Conversation

owent
Copy link
Member

@owent owent commented Apr 21, 2023

Fixes #2110

Changes

Please provide a brief description of the changes here.

  • Record aborted session and call it's FinishOperation.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@owent owent requested a review from a team April 21, 2023 09:07
@codecov
Copy link

codecov bot commented Apr 21, 2023

Codecov Report

Merging #2111 (7805c53) into main (6c7f7c8) will increase coverage by 0.03%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2111      +/-   ##
==========================================
+ Coverage   87.17%   87.19%   +0.03%     
==========================================
  Files         166      166              
  Lines        4784     4784              
==========================================
+ Hits         4170     4171       +1     
+ Misses        614      613       -1     

see 1 file with indirect coverage changes

Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only minor comments.

ext/src/http/client/curl/http_client_curl.cc Show resolved Hide resolved
owent added 2 commits April 23, 2023 11:16
Signed-off-by: owent <[email protected]>
Signed-off-by: owent <[email protected]>
@ThomsonTan ThomsonTan merged commit 6ca0d68 into open-telemetry:main Apr 27, 2023
@owent owent deleted the fix_2110 branch May 7, 2023 09:48
@marcalff marcalff changed the title Fix 2110 [EXPORTER] Fixed HTTP session cleanup on shutdown May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Http sessions will not be clean if it's abort without curl event notification.
4 participants