Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUILD] Build break with old curl, macro CURL_VERSION_BITS unknown #2102

Merged
merged 2 commits into from
Apr 19, 2023
Merged

[BUILD] Build break with old curl, macro CURL_VERSION_BITS unknown #2102

merged 2 commits into from
Apr 19, 2023

Conversation

marcalff
Copy link
Member

@marcalff marcalff commented Apr 19, 2023 •
edited
Loading

Fixes #2101

Changes

Provide macro CURL_VERSION_BITS, when building old (< 7.43.0) CURL versions.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@marcalff marcalff requested a review from a team April 19, 2023 10:07
owent
owent approved these changes Apr 19, 2023
View reviewed changes
Copy link
Member

@owent owent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Apr 19, 2023 •
edited
Loading

Codecov Report

Merging #2102 (4662e0a) into main (7cb7654) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2102   +/-   ##
=======================================
  Coverage   87.19%   87.19%           
=======================================
  Files         166      166           
  Lines        4784     4784           
=======================================
  Hits         4171     4171           
  Misses        613      613

@marcalff marcalff merged commit 82f2828 into open-telemetry:main Apr 19, 2023
@chenrui333 chenrui333 mentioned this pull request May 28, 2023
Closed
@marcalff marcalff deleted the fix_curl_build_2101 branch September 5, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owent owent owent approved these changes

@lalitb lalitb lalitb approved these changes

@ThomsonTan ThomsonTan ThomsonTan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUILD] Build break with old curl, macro CURL_VERSION_BITS unknown
4 participants
@marcalff @ThomsonTan @lalitb @owent