Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compile error with GCC 11.3 #2025

Merged
merged 2 commits into from
Mar 7, 2023

Conversation

tyler92
Copy link
Contributor

@tyler92 tyler92 commented Mar 7, 2023

Fixes #2026

Changes

There was a compile error with GCC 11.3 and the following cmake options:

-DBUILD_TESTING=OFF -DWITH_EXAMPLES_HTTP=ON -DWITH_PROMETHEUS=ON -DWITH_STL=ON

GCC output:

In file included from opentelemetry-cpp/examples/http/client.cc:7:
opentelemetry-cpp/examples/http/tracer_common.h:29:26: error: expected ‘)’ before ‘&’ token
   29 |   HttpTextMapCarrier<T>(T &headers) : headers_(headers) {}

See https://godbolt.org/z/Pv3fqq7zx

@tyler92 tyler92 requested a review from a team March 7, 2023 15:09
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 7, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@codecov
Copy link

codecov bot commented Mar 7, 2023

Codecov Report

Merging #2025 (6698434) into main (2b08db2) will increase coverage by 0.03%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2025      +/-   ##
==========================================
+ Coverage   87.30%   87.32%   +0.03%     
==========================================
  Files         166      166              
  Lines        4723     4723              
==========================================
+ Hits         4123     4124       +1     
+ Misses        600      599       -1     
Impacted Files Coverage Δ
sdk/src/trace/batch_span_processor.cc 91.48% <0.00%> (+0.78%) ⬆️

Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix.

Copy link
Member

@owent owent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and thanks.

@lalitb lalitb enabled auto-merge (squash) March 7, 2023 17:24
@ThomsonTan ThomsonTan mentioned this pull request Mar 7, 2023
3 tasks
@lalitb lalitb merged commit f732872 into open-telemetry:main Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compile error with GCC 11 WITH_STL=On
4 participants