-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OPENTELEMETRY_INSTALL
to allow user to skip install targets.
#2022
Conversation
Signed-off-by: owent <[email protected]>
Signed-off-by: owent <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks
if(NOT CMAKE_SOURCE_DIR STREQUAL CMAKE_CURRENT_SOURCE_DIR) | ||
set(OPENTELEMETRY_INSTALL_default ON) | ||
else() | ||
set(OPENTELEMETRY_INSTALL_default OFF) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Maybe this is too late now, but) Do you think this should default to ON in all cases for backwards compatibility?
Do you think the new feature should be listed in INSTALL.md?
Lines 75 to 86 in f702676
Some of the available cmake build variables we can use during cmake | |
configuration: | |
- `-DCMAKE_POSITION_INDEPENDENT_CODE=ON` : Please note that with default | |
configuration, the code is compiled without `-fpic` option, so it is not | |
suitable for inclusion in shared libraries. To enable the code for | |
inclusion in shared libraries, this variable is used. | |
- `-DBUILD_SHARED_LIBS=ON` : To build shared libraries for the targets. | |
Please refer to note [below](#building-shared-libs-for-windows) for | |
Windows DLL support. | |
- `-DWITH_OTLP=ON` : To enable building OTLP exporter. | |
- `-DWITH_PROMETHEUS=ON` : To enable building prometheus exporter. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Maybe this is too late now, but) Do you think this should default to ON in all cases for backwards compatibility?
True, somehow missed this during review. Not sure if reverting back would be good idea as the release is already done now. We can mention this in release summary as breaking change for builds cc @ThomsonTan ?
Fixes #2015
Changes
OPENTELEMETRY_INSTALL
to allow user to skip install targets.For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes