Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alpine packages to INSTALL.md #1957

Merged
merged 2 commits into from
Feb 6, 2023
Merged

Conversation

svrnm
Copy link
Member

@svrnm svrnm commented Feb 6, 2023

As discussed in #1950 a minor update to INSTALL.md to also mention the alpine packages.

@svrnm svrnm requested a review from a team February 6, 2023 15:34
@codecov
Copy link

codecov bot commented Feb 6, 2023

Codecov Report

Merging #1957 (4891e24) into main (c4c8ee0) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1957   +/-   ##
=======================================
  Coverage   87.10%   87.10%           
=======================================
  Files         165      165           
  Lines        4596     4596           
=======================================
  Hits         4003     4003           
  Misses        593      593           

INSTALL.md Outdated Show resolved Hide resolved
INSTALL.md Outdated Show resolved Hide resolved
Co-authored-by: Marc Alff <[email protected]>
Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks the the fix, and for the packages.

Copy link
Member

@esigo esigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks for the package :)

@esigo esigo added the ok-to-merge The PR is ok to merge (has two approves or raised by a maintainer/approver and has one approve) label Feb 6, 2023
@lalitb lalitb merged commit 2bae1c6 into open-telemetry:main Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-merge The PR is ok to merge (has two approves or raised by a maintainer/approver and has one approve)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants