-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert Prometheus Exporter to Pull MetricReader #1953
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lalitb
changed the title
Convert Prometheus Exporter to pull metric reader
Convert Prometheus Exporter to pull MetricReader
Feb 3, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1953 +/- ##
=======================================
Coverage 87.12% 87.12%
=======================================
Files 165 165
Lines 4596 4596
=======================================
Hits 4004 4004
Misses 592 592
|
This is ready for review now. @esigo - you know this code best, so would need your help in review :) |
lalitb
changed the title
Convert Prometheus Exporter to pull MetricReader
Convert Prometheus Exporter to Pull MetricReader
Feb 3, 2023
esigo
approved these changes
Feb 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix :)
changes look good just had one comment on the unit test
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1941
Changes
Changes are as explained here - #1941 (comment)
Prometheus Exporter now implements
MetricReader
class, instead ofPushMetricExporter
. And the metrics is collected only when the actual http pull request is received from Prometheus agent to fetch the metrics. Earlier metrics were fetched periodically by PeriodicMetricReader and stored into intermediate storage, from where the Prometheus agent used to pull the data. This resulted in duplicate entries of data in the intermediate storage.For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes