Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare v1.8.2 release #1947

Merged
merged 8 commits into from
Jan 31, 2023
Merged

Prepare v1.8.2 release #1947

merged 8 commits into from
Jan 31, 2023

Conversation

esigo
Copy link
Member

@esigo esigo commented Jan 31, 2023

No description provided.

@esigo esigo requested a review from a team January 31, 2023 16:57
marcalff
marcalff reviewed Jan 31, 2023
View reviewed changes
Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix this in new file DEPRECATED.md as well:

Version: TO-BE-RELEASED-VERSION
Date: TO-BE-RELEASED-DATE

@codecov
Copy link

codecov bot commented Jan 31, 2023 •
edited
Loading

Codecov Report

Merging #1947 (137dc11) into main (5b0adc7) will increase coverage by 0.03%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1947      +/-   ##
==========================================
+ Coverage   87.08%   87.10%   +0.03%     
==========================================
  Files         165      165              
  Lines        4596     4596              
==========================================
+ Hits         4002     4003       +1     
+ Misses        594      593       -1
Impacted Files Coverage Δ
sdk/src/trace/batch_span_processor.cc 90.70% <0.00%> (+0.78%) ⬆️

@esigo
Copy link
Member Author

esigo commented Jan 31, 2023

Please fix this in new file DEPRECATED.md as well:

Version: TO-BE-RELEASED-VERSION Date: TO-BE-RELEASED-DATE

@marcalff thanks, done!

marcalff
marcalff approved these changes Jan 31, 2023
View reviewed changes
Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM

ThomsonTan
ThomsonTan reviewed Jan 31, 2023
View reviewed changes
ThomsonTan
ThomsonTan approved these changes Jan 31, 2023
View reviewed changes
Copy link
Contributor

@ThomsonTan ThomsonTan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@esigo esigo enabled auto-merge (squash) January 31, 2023 18:56
@esigo esigo merged commit d56a5c7 into open-telemetry:main Jan 31, 2023
@esigo esigo deleted the pre_release_1.8.2 branch January 31, 2023 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomsonTan ThomsonTan ThomsonTan approved these changes

@lalitb lalitb lalitb approved these changes

@marcalff marcalff marcalff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@esigo @ThomsonTan @lalitb @marcalff