Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant macro check in nostd::shared_ptr #1939

Merged
merged 1 commit into from
Jan 27, 2023

Conversation

ThomsonTan
Copy link
Contributor

Fixes # (issue)

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@ThomsonTan ThomsonTan requested a review from a team January 27, 2023 00:25
Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lalitb lalitb enabled auto-merge (squash) January 27, 2023 00:36
@codecov
Copy link

codecov bot commented Jan 27, 2023

Codecov Report

Merging #1939 (dd1ddab) into main (52309dd) will decrease coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1939      +/-   ##
==========================================
- Coverage   87.12%   87.10%   -0.02%     
==========================================
  Files         165      165              
  Lines        4596     4596              
==========================================
- Hits         4004     4003       -1     
- Misses        592      593       +1     
Impacted Files Coverage Δ
api/include/opentelemetry/nostd/shared_ptr.h 100.00% <ø> (ø)
sdk/src/trace/batch_span_processor.cc 90.70% <0.00%> (-0.77%) ⬇️

@lalitb lalitb merged commit 7e7184d into open-telemetry:main Jan 27, 2023
@ThomsonTan ThomsonTan deleted the RemoveMacro branch February 24, 2023 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants