Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fix in INSTALL.md for enabling building package. #1930

Merged
merged 2 commits into from
Jan 18, 2023

Conversation

lalitb
Copy link
Member

@lalitb lalitb commented Jan 18, 2023

Changes

Please provide a brief description of the changes here.
Fix documentation to use cmake -DBUILD_PACKAGE=ON .. to configure building package.
For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@lalitb lalitb requested a review from a team January 18, 2023 19:04
@lalitb lalitb enabled auto-merge (squash) January 18, 2023 19:58
Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jan 18, 2023

Codecov Report

Merging #1930 (dbec91c) into main (7406b4f) will increase coverage by 0.03%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1930      +/-   ##
==========================================
+ Coverage   86.90%   86.92%   +0.03%     
==========================================
  Files         165      165              
  Lines        4594     4594              
==========================================
+ Hits         3992     3993       +1     
+ Misses        602      601       -1     
Impacted Files Coverage Δ
sdk/src/trace/batch_span_processor.cc 91.48% <0.00%> (+0.78%) ⬆️

@lalitb lalitb merged commit e8fce84 into open-telemetry:main Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants