fix SpinLockMutex for Intel Compiler #1885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1885 +/- ##
=======================================
Coverage 85.71% 85.71%
=======================================
Files 171 171
Lines 5240 5240
=======================================
Hits 4491 4491
Misses 749 749
|
owent
approved these changes
Dec 22, 2022
marcalff
approved these changes
Dec 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1771
Changes
see intel Pause Intrinsic doc
Include
immintrin.hand use_mm_pause()when__INTEL_COMPILERdefined.Could also use
sched_yield()fromsched.hbut the solution above seems to work.(This PR replaces the previous one because the CLAs could not be signed correctly)