Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resource and scope of new Logs SDK implementation. #1881

Merged
merged 2 commits into from
Dec 23, 2022

Conversation

owent
Copy link
Member

@owent owent commented Dec 22, 2022

Signed-off-by: WenTao Ou [email protected]

Fixes #1880

Changes

  • Fix missing scope and resource in new Logs implementation.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@owent owent requested a review from a team December 22, 2022 05:00
@codecov
Copy link

codecov bot commented Dec 22, 2022

Codecov Report

Merging #1881 (2d2a25e) into main (c0deb40) will decrease coverage by 0.04%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1881      +/-   ##
==========================================
- Coverage   85.77%   85.73%   -0.03%     
==========================================
  Files         171      171              
  Lines        5241     5241              
==========================================
- Hits         4495     4493       -2     
- Misses        746      748       +2     
Impacted Files Coverage Δ
ext/src/http/client/curl/http_client_curl.cc 80.31% <0.00%> (-1.13%) ⬇️
sdk/src/trace/batch_span_processor.cc 91.48% <0.00%> (+0.78%) ⬆️

Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix.

@lalitb lalitb enabled auto-merge (squash) December 23, 2022 07:31
@lalitb lalitb merged commit 94a6783 into open-telemetry:main Dec 23, 2022
@owent owent deleted the fix_1880 branch February 25, 2023 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logs do not set scope correctly.
2 participants