-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collect and Export metric data before PeriodicMetricReader shutdown. #1860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lalitb
changed the title
Metric reader shutdown
Collect and Exporte metric data before PeriodicMetricReader shutdown.
Dec 14, 2022
lalitb
changed the title
Collect and Exporte metric data before PeriodicMetricReader shutdown.
Collect and Export metric data before PeriodicMetricReader shutdown.
Dec 14, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1860 +/- ##
==========================================
+ Coverage 85.78% 85.78% +0.01%
==========================================
Files 171 171
Lines 5243 5252 +9
==========================================
+ Hits 4497 4505 +8
- Misses 746 747 +1
|
esigo
approved these changes
Jan 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for the PR :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1858
Changes
As discussed in this issue,
PeriodicMetricReader
should ensure the metric collection and export is done once before shutdown, for all the data points be uploaded. This is also supported in Java , and discussed in specs - open-telemetry/opentelemetry-specification#2983The shutdown sequence is:
MeterProvider::Shutdown()
->MeterContext::Shutdown()
->MetricCollector()
->Shutdown()
->MetricReader::Shutdown()
->PeriodicMetricReader::OnShutdown()
->
[[[Perform Collect and Shutdown ]]]
->MetricExporter::Shutdown()
This ensures that the MericExporter instance remains valid while MetricReader is doing collect-and-export during it's shutdown. Once the collect-and-export is completed, the MetricExporter is shutdown.
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes