Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small cleanup to remove old metrics design docs #1855

Merged
merged 3 commits into from
Dec 12, 2022

Conversation

lalitb
Copy link
Member

@lalitb lalitb commented Dec 9, 2022

Changes

Small cleanup to remove old metrics design docs
New architecture document is here - https://docs.google.com/document/d/17PiDI91MQy07kkiSJ7lvlnogvMD3FV85g__WEackj1M/edit?usp=sharing
Will add it separately.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@lalitb lalitb requested a review from a team December 9, 2022 19:38
@codecov
Copy link

codecov bot commented Dec 9, 2022

Codecov Report

Merging #1855 (fe5300b) into main (d30c140) will increase coverage by 0.08%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1855      +/-   ##
==========================================
+ Coverage   85.71%   85.79%   +0.08%     
==========================================
  Files         171      171              
  Lines        5240     5240              
==========================================
+ Hits         4491     4495       +4     
+ Misses        749      745       -4     
Impacted Files Coverage Δ
sdk/src/trace/batch_span_processor.cc 91.41% <0.00%> (+0.79%) ⬆️
ext/src/http/client/curl/http_client_curl.cc 81.44% <0.00%> (+1.14%) ⬆️

Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Thanks for the cleanup

Copy link
Member

@esigo esigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks for the PR :)

@lalitb lalitb merged commit f3daca0 into open-telemetry:main Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants