Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SEMANTIC CONVENTIONS] Upgrade to version 1.16.0 (#1853) #1854

Merged
merged 4 commits into from
Dec 12, 2022
Merged

[SEMANTIC CONVENTIONS] Upgrade to version 1.16.0 (#1853) #1854

merged 4 commits into from
Dec 12, 2022

Conversation

marcalff
Copy link
Member

@marcalff marcalff commented Dec 9, 2022 •
edited
Loading

Fixes #1853

Changes

Upgrade semantic conventions to opentelemetry-specification 1.16.0

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@marcalff marcalff requested a review from a team December 9, 2022 00:53
@codecov
Copy link

codecov bot commented Dec 9, 2022 •
edited
Loading

Codecov Report

Merging #1854 (1945694) into main (f1f6083) will decrease coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1854      +/-   ##
==========================================
- Coverage   85.73%   85.71%   -0.01%     
==========================================
  Files         171      171              
  Lines        5240     5240              
==========================================
- Hits         4492     4491       -1     
- Misses        748      749       +1
Impacted Files Coverage Δ
sdk/src/trace/batch_span_processor.cc 90.63% <0.00%> (-0.78%) ⬇️

lalitb
lalitb approved these changes Dec 9, 2022
View reviewed changes
Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@lalitb
Copy link
Member

lalitb commented Dec 9, 2022

@marcalff Can you fix the conflict, so it can be merged. Thanks.

esigo
esigo approved these changes Dec 11, 2022
View reviewed changes
Copy link
Member

@esigo esigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks for the PR :)

@lalitb lalitb merged commit d30c140 into open-telemetry:main Dec 12, 2022
@marcalff marcalff deleted the fix_sem_conv_1853 branch July 4, 2023 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esigo esigo esigo approved these changes

@lalitb lalitb lalitb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SEMANTIC CONVENTIONS] Upgrade to version 1.16.0
3 participants
@marcalff @lalitb @esigo