Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix console debug logs for otlp exporters. #1848

Merged
merged 1 commit into from
Dec 7, 2022

Conversation

marcalff
Copy link
Member

@marcalff marcalff commented Dec 7, 2022

Fixes #1847

Changes

Fixed console debug logs for otlp exporters.

  • Removed DEBUG: text from logs, redundant with OTEL_INTERNAL_LOG_DEBUG
  • Fixed a broken OTLP HTTP Client] tag
  • Added a space after FILE:LINE to separate from the log message
  • Added usage comments in examples
  • Set GlobalLogHandler::SetLogLevel(LogLevel::Debug) in examples when console_log is enabled
  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

Fixed console debug logs for otlp exporters.
@marcalff marcalff requested a review from a team December 7, 2022 10:53
@marcalff marcalff changed the title Fixed console debug logs for otlp exporters. Fix console debug logs for otlp exporters. Dec 7, 2022
@codecov
Copy link

codecov bot commented Dec 7, 2022

Codecov Report

Merging #1848 (9e1c450) into main (57bf8c2) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1848   +/-   ##
=======================================
  Coverage   85.73%   85.73%           
=======================================
  Files         171      171           
  Lines        5240     5240           
=======================================
  Hits         4492     4492           
  Misses        748      748           
Impacted Files Coverage Δ
sdk/src/common/global_log_handler.cc 87.50% <100.00%> (ø)

Copy link
Member

@owent owent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Copy link
Member

@esigo esigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks for the fix :)

@ThomsonTan ThomsonTan merged commit 41821d6 into open-telemetry:main Dec 7, 2022
@marcalff marcalff deleted the fix_console_debug_1847 branch July 4, 2023 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[EXAMPLES] console_debug not working in otlp exporter examples.
5 participants