Enable setting Span endtime for ETW exporter #1846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1846 +/- ##
=======================================
Coverage 85.73% 85.73%
=======================================
Files 171 171
Lines 5240 5240
=======================================
Hits 4492 4492
Misses 748 748 |
ThomsonTan
reviewed
Dec 8, 2022
| @@ -899,7 +899,15 @@ class Span : public opentelemetry::trace::Span | |||
| */ | |||
| void End(const opentelemetry::trace::EndSpanOptions &options = {}) noexcept override | |||
| { | |||
| end_time_ = std::chrono::system_clock::now(); | |||
| if (options.end_steady_time == opentelemetry::common::SteadyTimestamp()) | |||
There was a problem hiding this comment.
Update this to compare with 0 explicitly. And add TODO to choose a different value to represent "not set" status, as 0 is a valid value, and the user might set endtime to it.
ThomsonTan
approved these changes
Dec 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
While it is possible to set the end-time while ending span as per the spec, the ETW exporter use the endtime passed as argument in Span::End(). This PR fixes it.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes