Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default temporality as "Cumulative" for OTLP metrics exporters #1828

Merged
merged 3 commits into from
Dec 1, 2022

Conversation

lalitb
Copy link
Member

@lalitb lalitb commented Dec 1, 2022

Fixes #1821

Changes

Add default temporality as "Cumulative" for OTLP exporter - https://github.com/open-telemetry/opentelemetry-specification/blob/v1.15.0/specification/metrics/sdk_exporters/otlp.md#additional-configuration

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@lalitb lalitb requested a review from a team December 1, 2022 19:35
@lalitb lalitb changed the title fix Change default temporality as "Cumulative" for OTLP metrics exporters Dec 1, 2022
Copy link
Member

@esigo esigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks for the PR :)

@codecov
Copy link

codecov bot commented Dec 1, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@a24488f). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1828   +/-   ##
=======================================
  Coverage        ?   85.71%           
=======================================
  Files           ?      171           
  Lines           ?     5240           
  Branches        ?        0           
=======================================
  Hits            ?     4491           
  Misses          ?      749           
  Partials        ?        0           

@esigo esigo added area:exporter:otlp OpenTelemetry Protocol (OTLP) Exporter area:metrics OpenTelemetry metrics labels Dec 1, 2022
@lalitb lalitb enabled auto-merge (squash) December 1, 2022 22:26
@lalitb lalitb merged commit 2accc77 into open-telemetry:main Dec 1, 2022
yxue pushed a commit to yxue/opentelemetry-cpp that referenced this pull request Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:exporter:otlp OpenTelemetry Protocol (OTLP) Exporter area:metrics OpenTelemetry metrics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preferred aggregation temporality should be Cumulative?
2 participants