Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typo [affecting otlp exported histogram metrics max<uint>] #1827

Merged
merged 3 commits into from
Dec 2, 2022
Merged

fix typo [affecting otlp exported histogram metrics max<uint>] #1827

merged 3 commits into from
Dec 2, 2022

Conversation

ays7
Copy link
Contributor

@ays7 ays7 commented Dec 1, 2022

Changes

Trivial obvious typo affecting uint historgam max in otlp exported metrics

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@ays7 ays7 requested a review from a team December 1, 2022 17:05
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 1, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: ays7 / name: Alexey Shakula (5935afb)
  • ✅ login: esigo / name: Ehsan Saei (1b4ba49)

@lalitb lalitb added the pr:waiting-on-cla Waiting on CLA label Dec 1, 2022
@lalitb
Copy link
Member

lalitb commented Dec 1, 2022

@ays7 - thanks for the fix. Can you sign the CLA, for this to be ready for merge.

@esigo esigo changed the title fix silly typo [affecting otlp exported histogram metrics max<uint>] fix typo [affecting otlp exported histogram metrics max<uint>] Dec 1, 2022
@codecov
Copy link

codecov bot commented Dec 1, 2022 •
edited
Loading

Codecov Report

Merging #1827 (4d59b03) into main (f23c4a2) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1827   +/-   ##
=======================================
  Coverage   85.73%   85.73%           
=======================================
  Files         171      171           
  Lines        5240     5240           
=======================================
  Hits         4492     4492           
  Misses        748      748

@esigo esigo added area:exporter:otlp OpenTelemetry Protocol (OTLP) Exporter area:metrics OpenTelemetry metrics labels Dec 1, 2022
@marcalff marcalff removed the pr:waiting-on-cla Waiting on CLA label Dec 2, 2022
marcalff
marcalff approved these changes Dec 2, 2022
View reviewed changes
Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix.

@esigo esigo enabled auto-merge (squash) December 2, 2022 17:27
@esigo esigo merged commit 02bca21 into open-telemetry:main Dec 2, 2022
@ays7 ays7 deleted the fix_otlp_histogram_max branch December 2, 2022 22:48
yxue pushed a commit to yxue/opentelemetry-cpp that referenced this pull request Dec 5, 2022
@ays7 @yxue
fix silly typo [affecting otlp exported histogram metrics max<uint>] (o…
a4c5e0b 
…pen-telemetry#1827)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esigo esigo esigo approved these changes

@marcalff marcalff marcalff approved these changes

@lalitb lalitb lalitb approved these changes

@ThomsonTan ThomsonTan ThomsonTan approved these changes

Assignees
No one assigned
Labels
area:exporter:otlp OpenTelemetry Protocol (OTLP) Exporter area:metrics OpenTelemetry metrics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ays7 @lalitb @ThomsonTan @marcalff @esigo