Fix type mismatch when move nostd::shared_ptr

[owent]

Signed-off-by: owent [email protected]

Fixes #1806

Changes

Fix type mismatch when move nostd::shared_ptr.

[codecov]

Codecov Report

Merging #1815 (1c93d3a) into main (33d244a) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1815   +/-   ##
=======================================
  Coverage   85.73%   85.73%           
=======================================
  Files         171      171           
  Lines        5240     5240           
=======================================
  Hits         4492     4492           
  Misses        748      748           

Impacted Files	Coverage Δ
api/include/opentelemetry/nostd/shared_ptr.h	100.00% <100.00%> (ø)

[lalitb]

LGTM. Validated the changes, there is no crash with the fix. Thanks.

[marcalff]

Thanks for the fix.

I don't even understand the original std::shared_ptr code in the first place,
and the fix even less.

Some explanations would be welcome, to understand what is going on here.

[owent]

Thanks for the fix.

I don't even understand the original std::shared_ptr code in the first place,
and the fix even less.

Some explanations would be welcome, to understand what is going on here.

If we move a nostd::shared_ptr of derived class to a nostd::shared_ptr of base class,we will use the constructor of std::shared_ptr<derived class> in the buffer of nostd::shared_ptr<base class>.And when we use this nostd::shared_ptr<base class>, the buffer will be reinpreter cast to std::shared_ptr<base class>* before.