Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUILD] Fix benchmark CI #1808

Merged
merged 1 commit into from
Nov 25, 2022
Merged

[BUILD] Fix benchmark CI #1808

merged 1 commit into from
Nov 25, 2022

Conversation

esigo
Copy link
Member

@esigo esigo commented Nov 25, 2022

Fixes benchmark CI

Changes

Uses g++-10 in ubuntu latest
tested here

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@esigo esigo requested a review from a team November 25, 2022 20:43
@esigo esigo changed the title fix benchmark CI [BUILD] Fix benchmark CI Nov 25, 2022
@lalitb
Copy link
Member

lalitb commented Nov 25, 2022

This looks good, thanks - we can later also try with default compiler ( g++-11 ) on ubuntu-latest, with latest version of google benchmark v1.7.1 :)

@codecov
Copy link

codecov bot commented Nov 25, 2022

Codecov Report

Merging #1808 (7bc09a8) into main (e1b5611) will increase coverage by 0.04%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1808      +/-   ##
==========================================
+ Coverage   85.73%   85.77%   +0.04%     
==========================================
  Files         171      171              
  Lines        5240     5240              
==========================================
+ Hits         4492     4494       +2     
+ Misses        748      746       -2     
Impacted Files Coverage Δ
...include/opentelemetry/sdk/common/circular_buffer.h 98.00% <0.00%> (-2.00%) ⬇️
ext/src/http/client/curl/http_client_curl.cc 81.44% <0.00%> (+1.14%) ⬆️

@esigo esigo enabled auto-merge (squash) November 25, 2022 20:57
@esigo esigo merged commit 5642d1c into open-telemetry:main Nov 25, 2022
yxue pushed a commit to yxue/opentelemetry-cpp that referenced this pull request Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants