-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CI build #1798
Fix CI build #1798
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1798 +/- ##
==========================================
- Coverage 85.73% 85.73% -0.00%
==========================================
Files 171 171
Lines 5220 5240 +20
==========================================
+ Hits 4475 4492 +17
- Misses 745 748 +3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for the quick fix :)
Sorry, I am not fully in sync with the changes, so asking - There are issues in building the latest versions of asan, abeil and gRPC with gcc11, So we are using gcc 10 at all places ? |
Should it be added to doc if our repo doesn't work with gcc-11?
|
Fixes #1791
Changes
Fix CI build
ubuntu-latest upgraded from 20.04 to 22.04
ubuntu-20.04, used in CI before, had gcc 9 and gcc 10
ubuntu-22.04, used in CI now, has gcc 9, gcc 10 and gcc 11
Use gcc 10 instead of gcc 11 on ubuntu 22.04 (now latest), where this is sufficient.
Use ubuntu-20.04 when more dependencies fail (asan, abseil, grpc)
CHANGELOG.md
updated for non-trivial changes