Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clang-format in CI #1796

Merged
merged 1 commit into from
Nov 23, 2022
Merged

Conversation

marcalff
Copy link
Member

Fix clang-format in CI

Changes

ubuntu-20.04 contains:
Clang-format 10.0.0, 11.0.0, 12.0.0

ubuntu-22.04 contains:
Clang-format 12.0.1, 13.0.1, 14.0.0

Opentelemetry-cpp CI uses Clang-format 10 on ubuntu-latest.

This now breaks because ubuntu-latest was upgraded from 20.04 to 22.04.

Change the format workflow to use ubuntu 20.04 explicitly, to restore a working CI.

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@marcalff marcalff requested a review from a team November 23, 2022 08:55
@marcalff
Copy link
Member Author

@lalitb

The CI task CI / Format passes, please force push this fix to main to restore a working environment.

@marcalff marcalff added the pr:please-merge This PR is ready to be merged by a Maintainer (rebased, CI passed, has enough valid approvals, etc.) label Nov 23, 2022
@lalitb lalitb merged commit a0e98fb into open-telemetry:main Nov 23, 2022
yxue pushed a commit to yxue/opentelemetry-cpp that referenced this pull request Dec 5, 2022
@marcalff marcalff deleted the fix_ci_clang_format branch July 4, 2023 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:please-merge This PR is ready to be merged by a Maintainer (rebased, CI passed, has enough valid approvals, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants