Fix session lock of OtlpHttpClient
#1760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: owent <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1760 +/- ##
==========================================
+ Coverage 85.77% 85.79% +0.02%
==========================================
Files 171 171
Lines 5220 5220
==========================================
+ Hits 4477 4478 +1
+ Misses 743 742 -1
|
|
The failed job seems not a problem of this PR. |
lalitb
reviewed
Nov 10, 2022
| session_data.event_handle; | ||
| { | ||
| std::lock_guard<std::recursive_mutex> guard{session_manager_lock_}; | ||
| static_cast<ResponseHandler *>(handle.get())->Bind(this, *session); |
There was a problem hiding this comment.
Does this statement needs to be under lock ?
There was a problem hiding this comment.
No, it's not necessary, but I think ResponseHandler::Bind and inserting element into running_sessions_ below should work together logically.
|
|
||
| HttpSessionData &store_session_data = running_sessions_[key]; | ||
| store_session_data = std::move(session_data); | ||
| HttpSessionData &store_session_data = running_sessions_[session.get()]; |
There was a problem hiding this comment.
Just curious , why can't we just use session_data.session.get() instead of session.get() for indexing here?
There was a problem hiding this comment.
I believe it's same here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: owent [email protected]
Fixes #1759
Changes
OtlpHttpClientFor significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes