Fix typo in package name in documentation. #1636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a minor fix of a typo in the dependencies documentation.`@io_opentelemetry_cpp/api:with_abseil` is not a valid Bazel target name, it should instead be @io_opentelemetry_cpp//api:with_abseil.
lalitb
approved these changes
Sep 26, 2022
ThomsonTan
approved these changes
Sep 26, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1636 +/- ##
==========================================
+ Coverage 85.10% 85.12% +0.02%
==========================================
Files 159 159
Lines 4999 4999
==========================================
+ Hits 4254 4255 +1
+ Misses 745 744 -1
|
|
@davidmandle thanks for your contribution and welcome to OpenTelemetry! Would you clear the CLA #1636 (comment)? |
marcalff
approved these changes
Sep 27, 2022
Done! Thanks. |
yxue
pushed a commit
to yxue/opentelemetry-cpp
that referenced
this pull request
Dec 5, 2022
This is a minor fix of a typo in the dependencies documentation.`@io_opentelemetry_cpp/api:with_abseil` is not a valid Bazel target name, it should instead be @io_opentelemetry_cpp//api:with_abseil.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minor fix of a typo in the dependencies documentation.
@io_opentelemetry_cpp/api:with_abseilis not a valid Bazel target name, I believe that it should instead be @io_opentelemetry_cpp//api:with_abseil.