[Semantic Conventions] Align on the specification 1.13.0 #1625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1625 +/- ##
=======================================
Coverage 85.06% 85.06%
=======================================
Files 159 159
Lines 4999 4999
=======================================
Hits 4252 4252
Misses 747 747 |
|
@lalitb could you please take a look? I think we want to include this in the coming patch release. Should this be marked as breaking change, or probably no need as semantic convention itself is not in stable stage? |
lalitb
approved these changes
Sep 22, 2022
Yes, I think we can mark it as a breaking change, as there may be code changes required for instrumentation libraries. We don't need a major version upgrade as you rightly mentioned it as experimental. |
yxue
pushed a commit
to yxue/opentelemetry-cpp
that referenced
this pull request
Dec 5, 2022
…try#1625) * Fix open-telemetry#1624 * Added changelog
yxue
pushed a commit
to yxue/opentelemetry-cpp
that referenced
this pull request
Dec 5, 2022
…try#1625) * Fix open-telemetry#1624 * Added changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1624
Changes
Upgrade semantic conventions to opentelemetry-specification v1.13.0
BREAKING: rename
net.peer.iptonet.sock.peer.addr,net.host.iptonet.sock.host.addr,net.peer.nametonet.sock.peer.namefor socket-level instrumentation.See the opentelemetry-specification v.1.13.0 release notes,
section Semantic Conventions, for full details.
CHANGELOG.mdupdated for non-trivial changes