Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codecov ignore paths #1609

Merged
merged 2 commits into from
Sep 11, 2022
Merged

codecov ignore paths #1609

merged 2 commits into from
Sep 11, 2022

Conversation

esigo
Copy link
Member

@esigo esigo commented Sep 10, 2022

updates codecov ignore paths

Changes

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@esigo esigo requested a review from a team September 10, 2022 17:49
@codecov
Copy link

codecov bot commented Sep 10, 2022

Codecov Report

Merging #1609 (cbaa8bc) into main (13cb2ea) will decrease coverage by 0.09%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1609      +/-   ##
==========================================
- Coverage   85.06%   84.98%   -0.08%     
==========================================
  Files         156      156              
  Lines        4978     4978              
==========================================
- Hits         4234     4230       -4     
- Misses        744      748       +4     
Impacted Files Coverage Δ
...include/opentelemetry/sdk/common/circular_buffer.h 98.00% <0.00%> (-2.00%) ⬇️
ext/src/http/client/curl/http_client_curl.cc 80.31% <0.00%> (-1.13%) ⬇️

Copy link
Member

@owent owent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lalitb lalitb merged commit aedd610 into open-telemetry:main Sep 11, 2022
yxue pushed a commit to yxue/opentelemetry-cpp that referenced this pull request Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants