Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default value of OtlpHttpMetricExporterOptions::aggregation_temporality. #1601

Merged
merged 1 commit into from
Sep 9, 2022

Conversation

owent
Copy link
Member

@owent owent commented Sep 9, 2022

Signed-off-by: owent [email protected]

Fixes #1600

Changes

Fix default value of OtlpHttpMetricExporterOptions::aggregation_temporality.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@owent owent requested a review from a team September 9, 2022 06:45
@codecov
Copy link

codecov bot commented Sep 9, 2022

Codecov Report

Merging #1601 (e9da800) into main (b8504d9) will decrease coverage by 0.03%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1601      +/-   ##
==========================================
- Coverage   85.06%   85.04%   -0.02%     
==========================================
  Files         156      156              
  Lines        4978     4978              
==========================================
- Hits         4234     4233       -1     
- Misses        744      745       +1     
Impacted Files Coverage Δ
sdk/src/trace/batch_span_processor.cc 90.63% <0.00%> (-0.78%) ⬇️

@lalitb lalitb merged commit 13cb2ea into open-telemetry:main Sep 9, 2022
@owent owent deleted the fix_1600 branch September 9, 2022 18:38
yxue pushed a commit to yxue/opentelemetry-cpp that referenced this pull request Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OtlpHttpMetricExporterOptions should has the same default options as OtlpGrpcMetricExporterOptions
2 participants