Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Example for OTLP gRPC exporter for Metrics. #1598

Merged
merged 9 commits into from
Sep 13, 2022
Merged

Example for OTLP gRPC exporter for Metrics. #1598

merged 9 commits into from
Sep 13, 2022

Conversation

lalitb
Copy link
Member

@lalitb lalitb commented Sep 8, 2022 •
edited
Loading

Fixes #1593

Changes

  • Adds OTLP GRPC exporter example
  • Updates example README.md for metrics, and to use latest version of Collector
  • Update Collector config to by in sync with latest Collector version.

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@lalitb lalitb requested a review from a team September 8, 2022 07:15
@lalitb lalitb changed the title [WIP] - OTLP GRPC exporter example. [WIP] - Example for OTLP GRPC exporter for Metrics. Sep 8, 2022
@codecov
Copy link

codecov bot commented Sep 8, 2022 •
edited
Loading

Codecov Report

Merging #1598 (7cf199b) into main (c44fd91) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1598   +/-   ##
=======================================
  Coverage   85.26%   85.26%           
=======================================
  Files         156      156           
  Lines        4978     4978           
=======================================
  Hits         4244     4244           
  Misses        734      734

@lalitb lalitb changed the title [WIP] - Example for OTLP GRPC exporter for Metrics. Example for OTLP GRPC exporter for Metrics. Sep 8, 2022
@lalitb lalitb mentioned this pull request Sep 8, 2022
Closed
@lalitb lalitb changed the title Example for OTLP GRPC exporter for Metrics. Example for OTLP gRPC exporter for Metrics. Sep 8, 2022
esigo
esigo approved these changes Sep 10, 2022
View reviewed changes
Copy link
Member

@esigo esigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks for the PR

owent
owent reviewed Sep 11, 2022
View reviewed changes
examples/otlp/CMakeLists.txt Outdated Show resolved Hide resolved
@lalitb lalitb mentioned this pull request Sep 12, 2022
Merged
3 tasks
owent
owent approved these changes Sep 13, 2022
View reviewed changes
Copy link
Member

@owent owent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lalitb lalitb merged commit cfaf8a1 into open-telemetry:main Sep 13, 2022
yxue pushed a commit to yxue/opentelemetry-cpp that referenced this pull request Dec 5, 2022
@lalitb @yxue
Example for OTLP gRPC exporter for Metrics. (open-telemetry#1598)
519b338
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esigo esigo esigo approved these changes

@owent owent owent approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OTLP gRPC metrics exporter fails to connect
3 participants
@lalitb @owent @esigo