Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Histogram tests for Synchronous Metric Storage. #1597

Merged
merged 6 commits into from
Sep 12, 2022

Conversation

lalitb
Copy link
Member

@lalitb lalitb commented Sep 7, 2022

Changes

The histogram tests were missing for delta and cumulative.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@lalitb lalitb requested a review from a team September 7, 2022 20:36
@codecov
Copy link

codecov bot commented Sep 7, 2022

Codecov Report

Merging #1597 (e830714) into main (aedd610) will increase coverage by 0.29%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1597      +/-   ##
==========================================
+ Coverage   84.98%   85.26%   +0.29%     
==========================================
  Files         156      156              
  Lines        4978     4978              
==========================================
+ Hits         4230     4244      +14     
+ Misses        748      734      -14     
Impacted Files Coverage Δ
sdk/src/trace/batch_span_processor.cc 91.41% <0.00%> (+0.79%) ⬆️
ext/src/http/client/curl/http_client_curl.cc 81.44% <0.00%> (+1.14%) ⬆️
...etry/sdk/metrics/aggregation/default_aggregation.h 58.19% <0.00%> (+18.19%) ⬆️

Copy link
Member

@esigo esigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks for the PR :)

@lalitb lalitb merged commit 951768a into open-telemetry:main Sep 12, 2022
yxue pushed a commit to yxue/opentelemetry-cpp that referenced this pull request Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants