Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error log when getting a http error code #1581

Merged
merged 1 commit into from
Aug 25, 2022

Conversation

owent
Copy link
Member

@owent owent commented Aug 25, 2022

Signed-off-by: owent [email protected]

Fixes #1578

Changes

  • Add error log when OTLP HTTP exportor and ES exportor get a http error code

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@owent owent requested a review from a team August 25, 2022 09:24
@codecov
Copy link

codecov bot commented Aug 25, 2022

Codecov Report

Merging #1581 (041bdfe) into main (4535347) will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1581      +/-   ##
==========================================
- Coverage   85.02%   84.96%   -0.06%     
==========================================
  Files         156      156              
  Lines        4977     4977              
==========================================
- Hits         4231     4228       -3     
- Misses        746      749       +3     
Impacted Files Coverage Δ
ext/src/http/client/curl/http_client_curl.cc 80.31% <0.00%> (-1.13%) ⬇️

Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix.

@lalitb lalitb merged commit cecfc19 into open-telemetry:main Aug 25, 2022
@owent owent deleted the fix_1578 branch September 5, 2022 10:47
yxue pushed a commit to yxue/opentelemetry-cpp that referenced this pull request Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OTLP HTTP exporter errors are never reported
3 participants