Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove throw check from metrics with noexcept #1560

Merged
merged 2 commits into from
Aug 11, 2022
Merged

remove throw check from metrics with noexcept #1560

merged 2 commits into from
Aug 11, 2022

Conversation

esigo
Copy link
Member

@esigo esigo commented Aug 11, 2022

Fixes #1559 (issue)

Changes

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@esigo esigo requested a review from a team August 11, 2022 15:54
@codecov
Copy link

codecov bot commented Aug 11, 2022 •
edited
Loading

Codecov Report

Merging #1560 (bd8e3fc) into main (8844771) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1560      +/-   ##
==========================================
- Coverage   83.38%   83.36%   -0.02%     
==========================================
  Files         156      156              
  Lines        4975     4975              
==========================================
- Hits         4148     4147       -1     
- Misses        827      828       +1
Impacted Files Coverage Δ
sdk/src/trace/batch_span_processor.cc 90.63% <0.00%> (-0.78%) ⬇️

lalitb
lalitb approved these changes Aug 11, 2022
View reviewed changes
Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

@esigo esigo enabled auto-merge (squash) August 11, 2022 17:46
@esigo esigo merged commit 6c240fd into open-telemetry:main Aug 11, 2022
@esigo esigo deleted the metrics-noexept-test branch August 11, 2022 18:24
yxue pushed a commit to yxue/opentelemetry-cpp that referenced this pull request Dec 5, 2022
@esigo @yxue
remove throw check from metrics with noexcept (open-telemetry#1560)
c13679f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lalitb lalitb lalitb approved these changes

@ThomsonTan ThomsonTan ThomsonTan approved these changes

Assignees
No one assigned
Labels
build and test metrics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

remove throw check from metrics tests with noexcept
3 participants
@esigo @ThomsonTan @lalitb