Fix infinitely waiting when shutdown with more than one running http sessions. #1549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sessions. Signed-off-by: owentou <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1549 +/- ##
=======================================
Coverage 83.91% 83.91%
=======================================
Files 156 156
Lines 4908 4908
=======================================
Hits 4118 4118
Misses 790 790
|
esigo
reviewed
Aug 9, 2022
| @@ -1,6 +1,8 @@ | |||
| // Copyright The OpenTelemetry Authors | |||
| // SPDX-License-Identifier: Apache-2.0 | |||
|
|
|||
| #include <cstring> | |||
There was a problem hiding this comment.
Yes, memcpy need cstring, some versions of gcc can not compile without this.
yxue
pushed a commit
to yxue/opentelemetry-cpp
that referenced
this pull request
Dec 5, 2022
…sessions. (open-telemetry#1549) Signed-off-by: owentou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: owentou [email protected]
Fixes #1548