[METRICS SDK] Fix OTLP gRPC Metrics env variables #1543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lalitb
changed the title
ThomsonTan
reviewed
Aug 5, 2022
exporters/otlp/include/opentelemetry/exporters/otlp/otlp_environment.h
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #1543 +/- ##
=======================================
Coverage 83.91% 83.91%
=======================================
Files 156 156
Lines 4908 4908
=======================================
Hits 4118 4118
Misses 790 790 |
ThomsonTan
reviewed
Aug 5, 2022
exporters/otlp/include/opentelemetry/exporters/otlp/otlp_environment.h
Outdated
Show resolved
Hide resolved
ThomsonTan
approved these changes
Aug 5, 2022
esigo
approved these changes
Aug 6, 2022
exporters/otlp/include/opentelemetry/exporters/otlp/otlp_environment.h
Outdated
Show resolved
Hide resolved
yxue
pushed a commit
to yxue/opentelemetry-cpp
that referenced
this pull request
Dec 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # (issue)
Changes
Please provide a brief description of the changes here.
otlp gRPC Metrics exporter is reusing the env variable processing from otlp trace exporter, which is making it use env variables containing
_TRACE_instead of_METRICS_. This is fixed now.For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes