-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add configuration options for Aggregation creation #1513
Add configuration options for Aggregation creation #1513
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1513 +/- ##
==========================================
+ Coverage 84.63% 84.65% +0.03%
==========================================
Files 155 156 +1
Lines 4781 4794 +13
==========================================
+ Hits 4046 4058 +12
- Misses 735 736 +1
|
Thanks for the PR. Changes are nicely done. One suggestion - Should we expose the config api in the SDK and not the API. As of now, the instrumentation library shouldn't be able to specify the metrics configuration, it should be done only by SDK (through View API?). There have been some discussions earlier to expose the config through API - Configuring histograms in the API (hints?), Add the metrics API Hint - but was not added to specs. |
@lalitb thanks, removed from api. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the PR.
Fixes #1444 (issue)
Changes
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes